Repository navigation
feat(web): Settings › Secrets, and a Vaultwarden picker beside every secret field - #577
Merged
Merged
Conversation
…secret field Settings › Secrets sets up the Vaultwarden vault secret fields can refer to and tests its sign-in, and lists every field that refers to it with whether it could be read. Every secret field gets From Vaultwarden, which lists the vault's items by name and fills in a reference; a saved reference shows itself and its read status, never a value. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019okSDRfFHV74BTpMzinTFg
#400 shipped in 0.15.0, so make requirements failed on main with it still under In progress. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019okSDRfFHV74BTpMzinTFg
…-56g82s # Conflicts: # README.md # docs/requirements.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: secret fields could refer to Vaultwarden (#550), but only through the API, MCP or the assistant. The web app had no place to set the vault up, and you had to type each reference by hand.
After: Settings › Secrets sets up the vault (its address, Lens's account, the API key and the master password) and has a Test button. It also lists every field that refers to the vault, with whether each was read, linked to that field. Every secret field in Settings gets a From Vaultwarden button once a vault is set up. The button opens a search of the vault's items. Picking a field, or pressing Enter for the first match, fills in the reference. A saved reference shows as "From Vaultwarden ·
vaultwarden://…", with when it was read or why not. It never shows a value.How:
components/settings/vault-picker.tsxholds the picker and the reference status.SecretsProviderfetchesGET /secretsonly for sections that have a secret field.SecretSettinggains asavedprop, so it can show a saved reference. A reference is typed as text, not as a password. The Secrets section is part of Security and access, and checks the address before saving.Motivation and Context
This is the web half of Adeel's secrets manager. The backend is #550.
Types of changes
!in the title)Checklist:
__tests__/settings-secrets.test.tsxhas 7 tests: setting up the vault, refusing an address with a password in it, Test and the list of references, a saved reference's status, picking from the vault (only the reference is saved), Enter picks the first item, and no picker without a vault. The settings tests pass (104).docs/accordingly:docs/secrets.md, README anddocs/requirements.md.## UnreleasedinCHANGELOG.md.Done questions (AGENTS.md)
secrets.*setting is now editable in Settings › Secrets, with defaults. The folder and the cache time are under More. The setup wizard is unchanged.docs/secrets.mdand README move the web UI from Planned to Built. References in sources and MCP servers stay Planned.docs/secrets.md.SecretSetting,SearchInput, settings sections andsettingHref.🤖 Generated with Claude Code
https://claude.ai/code/session_019okSDRfFHV74BTpMzinTFg