Repository navigation
fix(telemetry): trace a worker's first job and keep collector credentials safe - #46
Merged
Merged
Conversation
…ials safe - A worker started with --steps now reads the saved settings at start, so telemetry is on before its first job's span - The endpoint can't carry user:password (it is stored and shown as is; credentials go in the sealed headers) or be a link-local address - Moving the endpoint to another host drops the saved headers, so a collector's token never goes to a new host; Settings says so on review Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CFYD76r8LUcnfTYKBwRfPn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Follow-ups from the review of #40.
lens worker --steps …didn't read the saved settings until its first job had already started, so that job had no span. Now the worker reads them when it starts.user:password@. The endpoint is stored and returned unsealed, so credentials are refused there and the error points to the sealed Headers instead.169.254.0.0/16andfe80::/10are refused.Motivation and Context
Findings from the independent review of #40.
Types of changes
!in the title)Checklist:
make hookschecks it on commit).docs/accordingly.## UnreleasedinCHANGELOG.md.🤖 Generated with Claude Code
https://claude.ai/code/session_01CFYD76r8LUcnfTYKBwRfPn
Generated by Claude Code