Repository navigation
fix(deps): upgrade @hey-api/openapi-ts to 0.99 and regenerate the client - #44
Merged
Merged
Conversation
Removes the critical handlebars and tar alerts from the generator's dependency tree and fixes the prototype-chain advisory in the generated client. The new client returns network failures as results; an error interceptor keeps them throwing as before, so an unreachable API is not mistaken for an API error. ESLint is dropped as a post-processor because eslint.config.mjs ignores the generated folder and ESLint exits non-zero on it. js-yaml 4 gets a security floor. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01YPDRcAu87qM3sf5WRoPWY6
adeelahmad
force-pushed
the
claude/fix-vulnerable-deps-hk9ud5
branch
from
October 2, 2026 14:11
8eb97fe to
d5ef22b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Description
Before: after #41,
pnpm auditstill reported 21 frontend advisories (2 critical). All of them came from@hey-api/openapi-ts0.83: handlebars, tar (through c12 and giget), and the generator's ownbuildClientParamsprototype-chain advisory.After:
pnpm auditreports no known vulnerabilities. Nothing changes for users.Motivation and Context
The 0.83 → 0.99 upgrade (held Dependabot #7) is the only fix for the handlebars and tar criticals, because 0.97+ no longer depends on either.
How:
@hey-api/openapi-tsis 0.99.0 andapp/openapi-clientis regenerated. Regenerating twice produces the same output.output.format/lintare replaced bypostProcess: ["prettier"]. ESLint was what failed partway through the earlier 0.99 attempt:eslint.config.mjsignores the generated folder, and ESLint exits 2 when every file it is given is ignored.{ error, response: undefined }instead of throwing.throwingNetworkErrors(lib/api/client.ts) adds an error interceptor to the server and browser clients so those requests still reject. Without it, signing in while the API is down would say "Wrong email or password".auth.tsandlib/auth/tokens.tsuseresponse?.statusto satisfy the new types.js-yaml@^4floor of 4.3.2, because the new ref-parser pins 4.2.0.Types of changes
Checklist:
make hookschecks it on commit).__tests__/api-client.test.ts: network failure rejects, HTTP error returns{error, response}, success returns data. The first test fails without the interceptor.)## UnreleasedinCHANGELOG.md.Checked locally, since no runner is available:
tsc, eslint and Prettier are clean. Jest passes 538/538.next buildsucceeds. The pre-commit hooks pass.Supersedes #7.
🤖 Generated with Claude Code
https://claude.ai/code/session_01YPDRcAu87qM3sf5WRoPWY6
Generated by Claude Code