Repository navigation
docs: audit findings — correct Rust MSRV (1.85 → 1.95) + drop stale note - #2
Closed
adeelahmad wants to merge 1 commit into
Closed
adeelahmad wants to merge 1 commit into
adeelahmad wants to merge 1 commit into
Conversation
The vendored md-db's `kdl` dependency (pinned kdl@6.7.1) requires rustc 1.95, so install.sh and `make test`/`make ci` fail to build md-db on any toolchain < 1.95 — but every doc still advertised ">= 1.85". Anyone on Rust 1.85–1.94 following the install instructions hit a hard md-db build failure (ctx-symbols alone still builds on older toolchains). Bump the documented floor to 1.95 across README, plugin/README, and install.sh. Also drop the README "Status" note telling readers to set the repository URL in plugin.json — it is already set to the public repo.
Owner
Author
|
Closing as superseded: master pins Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64A4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audit & review — agentic-agile plugin
Audited the plugin against the Claude Code platform docs + its own design docs, and exercised the test/gate machinery. Overall the plugin is in good shape; this PR fixes the one user-facing build-blocking discrepancy plus a stale note.
What was verified ✅
claude plugin validate ./plugin --strict→ passes.SubagentStart/SubagentStopare real hook events; thematcherfilters by agent type, andSubagentStopis blockable (exit 2) — so the "deterministic gate per sub-agent stop" premise is valid.name/description/model/tools); none rely onhooks/mcpServers/permissionMode(correctly ignored for plugin agents — SKILL.md already documents this).plugin.json/marketplace.jsonschemas,${CLAUDE_PLUGIN_ROOT}usage, and thehooks/hooks.jsonlayout are all correct.cargo test→ 17/17 pass.gate-structural-integrityreturns exit 0 on a clean tree and exit 2 (BLOCK) on a duplicate definition — verified with both the real ctx-symbols backend (count==1, HIGH→halt) and the grep fallback.make json·make eval-validate(10 suites) ·make version-check(0.3.1 in lockstep) all green.Finding fixed in this PR 🛠️
Documented Rust MSRV was stale (1.85) but the real build floor is 1.95.
The vendored
md-db'skdldependency (pinnedkdl@6.7.1, and the wholekdl 6.6+line) requiresrustc 1.95. On any toolchain in 1.85–1.94,./plugin/tools/install.shandmake test/make cifail to build md-db with a hardrustc 1.94.1 is not supported … kdl requires rustc 1.95error — directly contradicting the advertised ">= 1.85". (ctx-symbols alone still builds on older toolchains; CI is green because GitHub'sstablerunner is already ≥ 1.95.)This PR bumps the documented floor to 1.95 in
README.md,plugin/README.md, andinstall.sh, and removes the README "Status" note telling readers to set therepositoryURL inplugin.json(it is already set to the public repo).Note (not changed)
md-dbunit tests could not be run in this sandbox (rustc 1.94.1 < 1.95); they run in CI on stable. Worth pinning a CI Rust version if a stable MSRV guarantee is desired.https://claude.ai/code/session_01WukZQhJx1NqU19UVRds7Vh
Generated by Claude Code