Repository navigation
fix: refuse execution dispatches before the task contract exists - #9
Merged
Merged
Conversation
e2e run 6 (11/11, 11 min, $0.65): the supervisor dispatched the structural reviewer before writing its contract, and its gate blocked 25 times on a STORY_DIR the worker could not supply. gate-dispatch (PreToolUse Agent|Task) now refuses an execution-role dispatch without a 'TASK_ID: <id>' first line or before .agentic/state/tasks/<id>.env exists. Also: annotated scaffold-symbols lines no longer split into fake symbols. dispatch.test.py (6) and 1 conformance case (37 total) failed before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015QxyVf3NgwsgRyYpBgDDTC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adeel · project thread
Before: the supervisor could dispatch a worker before writing its task contract. In e2e run 6 that happened to the structural reviewer, and its gate then blocked 25 times on a
STORY_DIRthe worker had no way to supply. Separately, a scaffold-symbols line with notes on it (ParseError (enum) @ src/lib.rs) was split into fake symbols such as(enum)and@, and each one was reported as "defined 0 times".After: a new
gate-dispatch(PreToolUse on Agent/Task) refuses a dispatch to an execution role unless the prompt's first line isTASK_ID: <id>and.agentic/state/tasks/<id>.envalready exists. It only acts on the main session, and only in repos that have a.agentic/folder. The scaffold gate now takes the first token on each line as the symbol and drops anything that isn't an identifier.How: the new gate parses the hook payload. The symbol fix is an awk/grep filter in
gate-scaffold-verify.Evidence.
make ciis green locally.scripts/test/dispatch.test.pyhas 6 checks, and conformance is at 37 checks; the 6 dispatch checks and the new scaffold case all failed before the fix.Generated by Claude Code