-
Notifications
You must be signed in to change notification settings - Fork 100
Add -c / --container flag to images #603
Add -c / --container flag to images #603
Conversation
|
This is updated to use the correct name for the nested Acorn image and avoids any type of pull/lookup of the image. |
pkg/cli/images.go
Outdated
return out.Err() | ||
} | ||
|
||
type ImageContainer struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you unexport this (imageContainer) but keep the fields exported and see if it'll still work? I'm not 100% sure whether it will or not, but would be nice to keep it unexported if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, agreed. It's only needed for looping through all of this.
The new flags show the container images that are a part of the Acorn image. Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
6f678cd
to
10df193
Compare
Signed-off-by: Bill Maxwell <cloudnautique@users.noreply.github.com>
The output for New Output: acorn images
#REPOSITORY TAG IMAGE-ID
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff
#
acorn images -c
#REPOSITORY TAG IMAGE-ID CONTAINER DIGEST
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff registry sha256:1ea1b40d2a72e41d37b5a8d22552c89ad847600c9fed29a22b5446ae91d9e88a
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff htpasswd-create sha256:18eac8138e63f223f3e695494c11b0c49478cc59024780d004827fbd5bd0d86e
#ghcr.io/acorn-io/library/registry latest ghcr.io/acorn-io/library/registry:latest@sha256:363c28df7ed04e8a8813d558b696a0b010646f3021b25159696721d354732e95 redis-0-0 sha256:a9c957fd95370e75a266c926a2b740fbab4a28d7408ad29b1b9be8e2bd722f36 acorn images -a
#REPOSITORY TAG IMAGE-ID
#<none> <none> 2524a1a8c667
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff
acorn images -c -a
#REPOSITORY TAG IMAGE-ID CONTAINER DIGEST
#<none> <none> 2524a1a8c667 prom sha256:ef691daf5c0961759efcbaf6fa6dba37ea5e138e1447245fa9f10fdd71841f1d
#<none> <none> 2524a1a8c667 acorn-file-init sha256:b97a089c9869ffe80cf80942ec81fa3dbc0bca751f9b677f3875edf841105232
#<none> <none> 2524a1a8c667 acorn-monitoring-operator sha256:7d34aa6fc9374b39f35cd3e77705651a60b9286aee9564131b84096592968146
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff registry sha256:1ea1b40d2a72e41d37b5a8d22552c89ad847600c9fed29a22b5446ae91d9e88a
#ghcr.io/acorn-io/library/registry latest ddf2840f12ff htpasswd-create sha256:18eac8138e63f223f3e695494c11b0c49478cc59024780d004827fbd5bd0d86e
#ghcr.io/acorn-io/library/registry latest ghcr.io/acorn-io/library/registry:latest@sha256:363c28df7ed04e8a8813d558b696a0b010646f3021b25159696721d354732e95 redis-0-0 sha256:a9c957fd95370e75a266c926a2b740fbab4a28d7408ad29b1b9be8e2bd722f36 acorn images -c -q
#ghcr.io/acorn-io/library/registry:latest@sha256:1ea1b40d2a72e41d37b5a8d22552c89ad847600c9fed29a22b5446ae91d9e88a
#ghcr.io/acorn-io/library/registry:latest@sha256:18eac8138e63f223f3e695494c11b0c49478cc59024780d004827fbd5bd0d86e
#ghcr.io/acorn-io/library/registry:latest@sha256:a9c957fd95370e75a266c926a2b740fbab4a28d7408ad29b1b9be8e2bd722f36
acorn images -c -q -a
#<none>:2524a1a8c667aa80e8319f4741861ca2f60f046d2f52ebb59c0131115cec2b53@sha256:ef691daf5c0961759efcbaf6fa6dba37ea5e138e1447245fa9f10fdd71841f1d
#<none>:2524a1a8c667aa80e8319f4741861ca2f60f046d2f52ebb59c0131115cec2b53@sha256:b97a089c9869ffe80cf80942ec81fa3dbc0bca751f9b677f3875edf841105232
#<none>:2524a1a8c667aa80e8319f4741861ca2f60f046d2f52ebb59c0131115cec2b53@sha256:7d34aa6fc9374b39f35cd3e77705651a60b9286aee9564131b84096592968146
#ghcr.io/acorn-io/library/registry:latest@sha256:1ea1b40d2a72e41d37b5a8d22552c89ad847600c9fed29a22b5446ae91d9e88a
#ghcr.io/acorn-io/library/registry:latest@sha256:18eac8138e63f223f3e695494c11b0c49478cc59024780d004827fbd5bd0d86e
#ghcr.io/acorn-io/library/registry:latest@sha256:a9c957fd95370e75a266c926a2b740fbab4a28d7408ad29b1b9be8e2bd722f36 |
The new flags show the container images that are a part of the Acorn
image.
acorn images:
Signed-off-by: Bill Maxwell cloudnautique@users.noreply.github.com