8000 fix: recognize Windows absolute start directories by dajiaohuang · Pull Request #197 · abdfnx/tran · GitHub
[go: up one dir, main page]

Skip to content

fix: recognize Windows absolute start directories - #197

Merged
abdfnx merged 1 commit into
abdfnx:mainfrom
dajiaohuang:fix/windows-start-dir
Oct 22, 2026
Merged

abdfnx merged 1 commit into
abdfnx:mainfrom
dajiaohuang:fix/windows-start-dir

Conversation

@dajiaohuang
Copy link
Copy Markdown
Contributor

Summary

  • Recognize platform-absolute paths when selecting --start-dir, while preserving root-relative paths and relative paths.
  • Add focused tests for absolute, root-shortcut, and relative path classification.

Validation

  • Reproduced on Windows with task-local synthetic files: a drive-qualified absolute path was not recognized by the slash-prefix check, and joining it to the current directory produced an unusable path. After the fix, the same synthetic directory was selected and dfs.GetDirectoryListing returned its one synthetic entry.
  • go test -count=1 -mod=readonly ./dfs passed with task-local Go caches and GOPROXY=off.
  • No Tran process, transfer, listener, or real user file was used. Full TUI/project build and tests were not run; no dependency restore was attempted.

No related issue is linked; the broad feature request was not treated as evidence for this fix.

@dajiaohuang
dajiaohuang requested a review from abdfnx as a code owner October 21, 2026 16:48
@abdfnx
abdfnx commented Oct 22, 2026
Copy link
Copy Markdown
Owner

Thanks

@abdfnx
abdfnx merged commit 81a4363 into abdfnx:main Oct 22, 2026
Sign up for free to join this conv 687F ersation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0