Repository navigation
Conversation
Check-ins now carry only the hashed cluster ID, license ID, version and node count. Align README benefits order and data copy with MESSAGING.md, and the chart README and configuration docs.
- A verified lease's lic_exp now sets the license end in both directions. - Expired, revoked and suspended check-in answers trigger an immediate resync (throttled to one per 5 minutes). - Signed requests and activations carry server-corrected time from srv_time / X-Kwatch-Srv-Time; one retry after stale_timestamp. - Activate and move retry once on nonce_reused and send ts. - The lease and clock guard are stored as one record and mirrored to the kwatch-license-instance Secret, so emptyDir keeps offline grace. - Init raises the clock guard to the cached lease's signed time. - Retry backoff gets ±20% jitter.
The 30-minute ping, its client and the clusterCheckins setting are gone. clusterCheckins and KWATCH_CLUSTER_CHECKINS are still accepted, ignored and logged once as deprecated, so existing config, KwatchConfig objects and Helm values keep loading. Pro now talks to api.kwatch.dev only for the daily license renewal; docs point to heartbeatMonitor.url for knowing when kwatch stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for detection, root cause, paging, messages and runtime. This PR also includes the license client hardening and the removal of cluster check-ins (previously #568).
Licensing and privacy
clusterCheckinssetting are gone.clusterCheckins(in the file, a KwatchConfig or Helm values) andKWATCH_CLUSTER_CHECKINSare still accepted, but they are ignored and logged once as deprecated. The CRD and Helm schema keep the field, so validation still passes. A revocation now takes effect at the next daily renewal, about 25 hours later. The docs now point toheartbeatMonitor.urlfor knowing when kwatch stops.lic_exp, that date is the license end. A later date extends the license and an earlier one ends it early.srv_time, thenX-Kwatch-Srv-Time, thenDate. kwatch keeps the offset to the server and uses it only to timestamp signed renew/deactivate requests and activate/move. Onstale_timestampit updates the offset and retries once. A second rejection is treated as a temporary failure and the state stays the same.tsand retry once on409 nonce_reused. A429 rate_limitedwithRetry-Afteris honoured and is not treated as a suspension.lease-cachefield ofkwatch-license-instance, so offline grace survives a lost volume. On load, kwatch takes the newer verified lease and the later guard. The Secret hashelm.sh/resource-policy: keep, sohelm uninstallkeeps it (this is documented).iat/srv_time.API protocol assumptions (abahmed/kwatch-api#13)
X-Kwatch-Srv-Timeis unix seconds on every/license/*response. The body'ssrv_timetakes precedence.tson activate/move is unix seconds, allowed ±600s, rejected with400 stale_timestamp.409 {"error":"nonce_reused"}on activate/move.expis at mostlic_exp. The client does not depend on this./license/pingis no longer called. The server can keep accepting old clients.Compatibility
An older kwatch build cannot parse the new lease record in the state file. It activates online again once.
Checks
make verify-focusedon license, app, config and api passed. The disk was low, so I used this instead of the fullmake verify.go test -raceon the same packages passed.-tags licenseteston license and app passed.make verify-catalogsandmake docs-verifypassed.make ci, e2e and helm tests.