Repository navigation
fix(core): release a reveal whose element has focus at the start - #330
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a target already has focus at the start,
observe()calls its callback at once, and the callback cancelled the animations withgroup.dispose().reveal()andcascade()readanimation.finishedafter that cancel, andcancel()replacesfinishedwith a new promise. That promise stays pending, so the reveal was never released, and the listener for reduced motion kept the target until an explicitdispose().The focus branch now calls
release(), which disconnects, cancels the group and removes the listener at once. The release no longer depends on the order of thefinishedread.disconnectis set afterobserve()returns, because the callback can run before that.A browser test in "release without dispose" focuses a link in the target before
reveal()and expects that all listeners are removed. It fails in Chromium without the fix.cascade()uses the samestart()function and release path asreveal(), so the test covers both. A separate cascade test would only duplicate it.Checklist
nextbranch.!and aBREAKING CHANGE:footer.