8000 ci: tolerate a published version and retry 5xx in the publish job by morellodev · Pull Request #334 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

ci: tolerate a published version and retry 5xx in the publish job - #334

Merged
morellodev merged 1 commit into
nextfrom
ci/tolerate-published-on-rerun
Oct 22, 2026
Merged

ci: tolerate a published version and retry 5xx in the publish job#334
morellodev merged 1 commit into
nextfrom
ci/tolerate-published-on-rerun

Conversation

@morellodev
@morellodev morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator

Summary

The next.12 release (run 39736965876) needed three attempts:

  1. npm returned 503 for @awesome-reveal/vue. pnpm does not retry a publish, so the job failed.
  2. The re-run tried to publish @awesome-reveal/astro again. The version was still in the npm malware scan, so pnpm's check did not see it. npm answered 403 You cannot publish over the previously published versions: 1.0.0-next.12., and the job stopped before Vue.
  3. The third attempt passed.

The publish step now does what changesets, lerna and Nx release do:

  • A "previously published versions: " or "previously staged version" answer counts as published. A plain 403 can be an OIDC error, so the step matches the exact text, not the status.
  • A 5xx answer gets 3 retries, after 30, 60 and 90 seconds. A retry after an upload that landed gets one of the two answers above.
  • pnpm wraps its errors at 80 columns with │, so the step joins the lines before the match.
  • The final wait_for_npm is still the real check.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. The repo has no workflow tests. actionlint passes, and a local harness ran the publish() function with a fake pnpm and the real error output of the run. These 8 cases pass: 403 same and other version, wrapped 409, 403 OIDC, 503 then ok, 503 then 403, 503 always, ok.
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. It does not apply: the change is in CI only.

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-22T07:17:02.653574Z afe5bd9 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Can't wait for the next one!

Reviewed commit: 6011bebd46

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 22, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@morellodev
morellodev force-pushed the ci/tolerate-published-on-rerun branch from 6011beb to afe5bd9 Compare October 22, 2026 07:15
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 22, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: afe5bd9a6e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit 1447a60 into next Oct 22, 2026
19 checks passed
@morellodev
morellodev deleted the ci/tolerate-published-on-rerun branch October 22, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0