8000 test: run the tests in real browsers with vitest browser mode by morellodev · Pull Request #326 · awesome-reveal/awesome-reveal · GitHub
[go: up one dir, main page]
Skip to content

test: run the tests in real browsers with vitest browser mode - #326

Merged
morellodev merged 26 commits into
nextfrom
test/browser-mode
Oct 18, 2026
Merged

test: run the tests in real browsers with vitest browser mode#326
morellodev merged 26 commits into
nextfrom
test/browser-mode

Conversation

@morellodev
@morellodev morellodev commented Oct 18, 2026
Copy link
Copy Markdown
Collaborator

Summary

Run all DOM tests in real browsers with Vitest browser mode and Playwright (Chromium, Firefox and WebKit), and remove jsdom.

  • The tests use the real IntersectionObserver and the Web Animations API. The spies in @awesome-reveal/test-utils call the real API. Only fault injection (vi.stubGlobal, invalid input, withoutAnimate(), rejectEasing()) replaces a browser behavior.
  • The shared contract suite runs in browser mode for React (vitest-browser-react), Vue (vitest-browser-vue) and Astro. It mounts below the fold and scrolls the real page.
  • The pure core logic stays in fast Node :unit tests. The old astro:browser project is now astro:e2e.
  • Remove jsdom, @testing-library/*, @vue/test-utils as a direct dependency, and the fake observer and animate.
  • The framework CI job runs the browser projects in Chromium with React 18, Astro 6 and the new Vue 3.5.0 entry. It uploads the failure screenshots and traces.
  • The pre-commit hook runs only oxlint and oxfmt. CI runs the tests. vitest related also fails on the React and Vue browser projects: Vitest 5.0.3 transforms the sources in the SSR environment, and vite:css-post throws on the reveal.css import there.
  • Update AGENTS.md, CONTRIBUTING.md, the .claude rules and the adapter skill.

No src/ file of a published package changes.

Admin action at merge: add Test (Vue 3.5.0) to the "Require CI" ruleset. Do not add it before the merge, because the other open PRs to next do not have this job.

Checklist

  • The PR targets the next branch.
  • The PR title follows Conventional Commits. A breaking change has ! and a BREAKING CHANGE: footer.
  • Tests cover the change. pnpm test --coverage: 60 files and 1498 tests pass in the three browsers, with coverage 100 / 97.8 / 100 / 100.
  • A change to an option, a default or an export also updates the READMEs, the consumer skills and the examples. Does not apply: no option, default or export changes.

@morellodev
test: add shared browser helpers and a reduced motion command
3a7523c
@morellodev
test: strengthen the checks of the browser test helpers
3aacdb9
@morellodev
test: test the pure core logic in node
12517e4
@morellodev
test: keep the core bundle size of the pure logic tests
8c6b5ef
@morellodev
test: move the core dom tests to browser mode
6aa65a5
@morellodev
test: tighten the core browser tests
48d76ac
@morellodev
test: run the contract and the react tests in browser mode
68c8316
@morellodev
test: share the browser test helpers of the contract
f058a7e
@morellodev
test: run the vue tests in browser mode
3aed33a
@morellodev
test: tighten the vue browser tests
05c0eb3
@morellodev
test: run the astro tests in browser mode, and rename the e2e project
0be7d89
@morellodev
build: remove jsdom and the test fakes
e2e33c6
@morellodev
ci: run the browser tests with the older framework versions
09b1172
@morellodev
build: run the related browser tests in the pre-commit hook
1e050ed
@morellodev
docs: describe the browser mode tests
7a73e6c
@morellodev
docs: fix the reduced motion advice and shorten the test rules
aec9622
@morellodev
test: close the gaps that the final review found
6d57f83
@morellodev
ci: upload the browser test results of the framework job
d282dcb
@morellodev
docs: clarify the repeats advice in the browser test rule
8fb92b3
@morellodev
build: run the react and vue browser projects in full in the pre-comm…
c683ab5 
…it hook
@morellodev
build: run the framework browser projects only for source changes of …
1e1cebc 
…core
@morellodev
build: remove the tests from the pre-commit hook
878756d
@morellodev
morellodev commented Oct 18, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 18, 2026 •
edited
Loading
Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T12:32:00.169302Z 109ad27 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 18, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 878756d543

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 18, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@morellodev
morellodev commented Oct 18, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 18, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: 63bf127539

ℹ️ About Codex in GitHub 8000

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev commented Oct 18, 2026
Copy link
Copy Markdown
Collaborator Author

@codex review

morellodev
morellodev commented Oct 18, 2026
View reviewed changes
Comment thread packages/core/src/animation.ts Resolved
@chatgpt-codex-connector
chatgpt-codex-connector Bot commented Oct 18, 2026
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: 109ad279aa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@morellodev
morellodev merged commit 3d92a3a into next Oct 18, 2026
19 checks passed
@morellodev
morellodev deleted the test/browser-mode branch October 18, 2026 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@morellodev
0