Repository navigation
perf!: run the generated entrance on the compositor - #316
Merged
Merged
Conversation
BREAKING CHANGE: the generated entrance replaces the element's own values of the properties that the start state sets (translate, scale, rotate, filter, opacity) while the element waits and during the entrance, and ends at their neutral values, so a fade now ends at opacity 1. The element's own transform still applies. To keep one of these values during the entrance, put it on an inner element or use native keyframes.
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ca8c7b47b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The default
fromentrance stuttered when the main thread was busy. A Chromium trace showed the cause. Every generated keyframe usedcomposite: "add", and Chromium does not composite an effect that has an additive keyframe (kEffectHasNonReplaceCompositeMode). The fade and the move both ran on the main thread.The generated entrance now uses only replace keyframes, with explicit neutral end values. It still has no implicit keyframes.
compositeFailed: 1616transform4096(kFilterRelatedPropertyMayMovePixels)Trade-off:
transformstill applies.translate,scale,rotate,filterandopacity.getComputedStyle.reveal.cssforcesopacity: 0, and a read forces a style recalculation for each target.Doc changes:
adding-reveal-animationsskills and the core rule describe the new behavior and the blur cost.composite, which set Firefox 80 and Safari 16. The individual transform properties now set the Chrome and Safari minimums. Optional chaining in theesnextoutput sets the Firefox minimum. The versions come from BCD and web-features, not from a test run. A native keyframe withcompositestill needs Firefox 80 or Safari 16, and the README says so.Checklist
nextbranch.!and aBREAKING CHANGE:footer.translateandopacity, so it keeps its ownrotate.)BREAKING CHANGE: the generated entrance replaces the element's own values of the properties that the start state sets (translate, scale, rotate, filter, opacity) while the element waits and during the entrance, and ends at their neutral values, so a fade now ends at opacity 1. The element's own transform still applies. To keep one of these values during the entrance, put it on an inner element or use native keyframes.