Repository navigation
fix(vue): build Reveal on createReveal and play on the new element when as and when change together - #279
Conversation
…en as and when change together
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@chatgpt-codex-connector thanks for the review. I pushed two follow-up commits (the review contract now covers element replacement, and |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 67e2f8c45f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Phase 5.4 of the stabilization plan. The Vue
Revealcomponent usescreateRevealfrom core. It has no observe, play orwhenlogic of its own.Revealmirrorsrevealedwithsubscribe, gives the element to core with a function ref, and applies the options in a post-flush watcher. A pre-flush watcher ran while the old element was still attached, so anaschange with awhenchange in the same tick played the animation on the old element. The new element did not play. A test covers it.v-revealis unchanged in code. It already usesreveal(), so it has the core fixes. The README and skill now say that it restores your inlineopacity. With server rendering it cannot, and the docs say so.v-reveal(newkeyor tag) starts a new reveal, because a directive keeps no state across elements. The contract harness has aboundToElementflag for this, and a test covers it. The docs describe the limit.Revealwithslideis 4100 bytes (3993 now). The limit of the directive stays at 3350 (3312). Gzipped: about 1.7 kB and 1.5 kB. The README is updated.examples/vuePageSection.vueuses a scoped style, with no inline style.Checklist
nextbranch.!and aBREAKING CHANGE:footer. This change is not breaking.v-reveal.