[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More module preliminaries #903

Merged

Conversation

Paul-Licameli
Copy link
Collaborator

Various changes in CMake programming to allow libraries (distinct from extension modules), fix modules dependent on other modules, and save some object file space by stripping unneeded symbols

@Paul-Licameli Paul-Licameli marked this pull request as draft May 18, 2021 04:25
Copy link
Contributor
@crsib crsib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I was sure, that this one was merged already.

@Paul-Licameli Paul-Licameli marked this pull request as ready for review May 18, 2021 13:23
@Paul-Licameli
Copy link
Collaborator Author

I withdrew the first of these commits from #839 when you said it would conflict with your work, but here it is again.

The second is one I should have included in #839.

I withheld the third of these until other discussion with you yesterday.

@Paul-Licameli Paul-Licameli merged commit b1f05e5 into audacity:master May 18, 2021
@Paul-Licameli Paul-Licameli deleted the more-module-preliminaries branch May 18, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants