Module manager changes #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89423ef
to
c741cf7
Compare
|
Rebased, fixed build problems (I was relying on precompiled headers before), force pushed |
lllucius
approved these changes
May 15, 2021
There was a problem hiding this comment.
Built just fine on Windows (64-bit Debug build). Had to manually create the “bin/Debug/Modules” directory and copy mod-script-pipe into it before Audacity found it, but it did and it enabled just fine.
It build fine on Linux as well and mod-script-pipe works fine.
... Forcing appropriate failure to load modules with unsatisfied symbols on all platforms.
... Repeatedly pass through the list of modules that need to be opened, so long as the list is not empty and at least one module loaded in the last pass. This discovers dependencies of modules on other modules, avoiding the need to describe the dependencies and make one pass in some topologically sorted order. Which would be smarter, but would require much other work.
... The standard module dispatch can do that.
... It ended up not used, and long ago superseded by other TrackPanel reorganization. Such things as that (and many more) will be implemented with different idioms (registries in various higher level code) without requiring changes in this low level protocol for loading modules.
... Forcing other places that use RegisterBuiltinModule to be more explicit about their link dependencies on ModuleManager, with a new #include directive. Does this make scripts/graph.pl show a new dependency cycle? Happily no. But now we know.
... So that the plugin providers might themselves become modules, and so that putting built-in commands and effects into modules will work
... All is set up so that plug-in providers can be modules that register their instance-creating function pointers directly with RegisterProvider; no special symbol name needs to be exported. That is, they now just need to export ModuleDispatch and GetVersionString, just like other modules for other purposes. Duplication of logic from ModuleManager::InitializeBuiltins() is removed. No examples yet in the previous commits, but it does work in my misc-modules branch.
c741cf7
to
dcdddcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various things cherry-picked out of my big misc-modules branch, related to the Module Manager.
Among these:
enabling loading of modules that depend on other modules, without any explicit description of those dependencies;
un-cluttering the simple protocol of symbols exposed by the modules, by eliminating special script pipe and track panel hijack hooks (alternative means can be found now for such things);
remove link dependency of ModuleManager on the GUI-heavy ModulePrefs page that interacts with it;
make it possible for plug-in providers to be just another kind of module, so that built-in or non-built-in ones will not need to be implemented differently.