[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playback. When a user makes a selection, the play / stop behaviour matches AU3 #7721

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Eism
Copy link
Collaborator
@Eism Eism commented Nov 14, 2024

Resolves: #7648

@Eism Eism requested a review from kryksyh November 14, 2024 15:20
@Eism Eism marked this pull request as draft November 14, 2024 15:20
@Eism Eism removed the request for review from kryksyh November 14, 2024 15:20
@Tantacrul
Copy link
Tantacrul commented Nov 14, 2024

@Eism I made a comment on Slack about the behaviour when a user double-clicks on a clip. We can discuss in the morning.

I'll repeat here:


For regular wave selections, it works as I'd expect.

  • When I make a wave selection and press play, it plays through the selection and then stops. Great!

However, there's one issue: when a user double-clicks on a clip, in AU3, that made a waveform selection, whereas in AU4, it makes a new type of clip selection. Hence, pressing 'Play' will do something different in AU3 and AU4 when you've double-clicked on a waveform.

  1. In AU4, when a user normally selects a full clip by clicking on its header - or if the user selects a group of clips, playback should not be affected by that. It shouldn't play at the start of the clip and stop at the end. So we'd need a special rule just for double-clicking on a waveform in AU4.

  2. One option is: if you double-click on waveform in AU4 (which selects the full clip), then in that specific circumstance, when the user presses Play, it should play from the start of the clip until the end, then stop.

  3. However, if point 2 is highly awkward, then we might consider going back to the idea that when you double-click on a waveform, it simply extends the wave selection to the ends of the clip, just like AU3 (see below), and we ditch the idea of double-clicking to select the full clip.

I'm curious whether either of these routes is difficult. I'm not sure which option I'd choose.
@LWinterberg any thoughts?

@Eism Eism marked this pull request as ready for review November 18, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation task. When a user makes a selection, the play / stop behaviour matches AU3
2 participants