Repository navigation
feat(progress): show estimated time remaining - #6
Merged
Merged
Conversation
osmanahmadxai
approved these changes
Oct 4, 2026
Owner
There was a problem hiding this comment.
Thanks! Reviewed and tested locally (fmt, clippy, all tests). The ETA is guarded against underflow and hidden on completion, and the narrower bar keeps the worst-case line (" ~59m 59s left" with 9-character sizes) within 80 columns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
70C1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Summary of Changes
~1m 20s left) to the terminal progress bar once transfer rate is non-zero, hiding it when finished.crate::util::format_duration.finished: boolinProgressso that the final draw upon completion clears the ETA text.BAR_WIDTHfrom 20 to 10 characters so that the entire line reliably stays