Repository navigation
Ignore empty entries when splitting skip-package filter - #1691
Open
princejain756 wants to merge 1 commit into
Open
princejain756 wants to merge 1 commit into
princejain756 wants to merge 1 commit into
Conversation
When splitting the comma-separated `skip-package` flag, a trailing, leading, or consecutive comma produces an empty string entry. Passing that empty string to `strings.Contains(suites[idx].Path, skipFilter)` matches every suite path and causes Ginkgo to skip all packages and exit 0. Trim whitespace around each `skip-package` entry and skip empty entries before checking `strings.Contains`. Fixes onsi#1690
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cliConfig.SkipPackageon commas inFindSuites.skip-packageproduced an empty filter entry that matched every suite path viastrings.Contains, causing unrelated test suites to be markedTestSuiteStateSkippedByFilter.ginkgo/internal/testsuite_test.gofor empty and whitespace-only entries inskip-package.Fixes #1690