Repository navigation
Precompile the fixture in the suite-timeout integration test - #1689
Merged
Merged
Conversation
ginkgo's --timeout clock starts before it compiles the suite. On a loaded CI runner, compiling the hanging fixture could eat most of the 5s timeout, so the spec never printed "Sleeping..." and the test failed. It has flaked this way on master four times since August. Build the fixture first, as the neighbouring interrupt test already does, then run the precompiled binary with the timeout. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PHpCwq4zwCazRetYBgay4u
onsi
marked this pull request as ready for review
October 9, 2026 23:36
onsi
added a commit
that referenced
this pull request
Nov 2, 2026
This is the same flake #1689 fixed for its neighbour. ginkgo's --timeout clock starts before it compiles, and on a loaded CI runner (with -race) compiling the four timeout fixtures used up the whole 10s budget. Ginkgo then reported that all four suites "did not run because the timeout elapsed" before TimeoutA ever started. This failed the master build for db1c4c8. The test now builds the fixtures first and runs the precompiled binaries. They keep the same suite names and paths in the output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FockBur8KAmXY5teeBBkn7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interrupt and Timeout when the suite times outhas failed on master 4 times since August, most recently 38002110196. Each time it failed atgbytes.Say("Sleeping..."): the hanging fixture never got far enough to print anything.The
ginkgo --timeoutclock starts before compilation (ginkgo/run/run_command.go). On a loaded runner, compiling the fixture could use up most of the test's 5s budget.The fix builds the fixture with
ginkgo buildfirst, the same way the neighbouring interrupt test does. It then runs./hanging.testwith the timeout, so the 5s covers only the suite run.The spec passes locally with
-race.🤖 Generated with Claude Code
https://claude.ai/code/session_01PHpCwq4zwCazRetYBgay4u