8000 Report invalid focus and skip regexps as configuration errors by Boulea7 · Pull Request #1686 · onsi/ginkgo · GitHub
[go: up one dir, main page]

Skip to content
8000

Report invalid focus and skip regexps as configuration errors - #1686

Open
Boulea7 wants to merge 2 commits into
onsi:masterfrom
Boulea7:ln-cx/fix-1257-invalid-text-filters
Open

Boulea7 wants to merge 2 commits into
onsi:masterfrom
Boulea7:ln-cx/fix-1257-invalid-text-filters

Conversation

@Boulea7
@Boulea7 Boulea7 commented Sep 29, 2026
Copy link
Copy Markdown
Contributor

Invalid --focus or --skip regular expressions currently panic. Validate the final OR-joined expressions in VetConfig, after suite overrides, so they produce configuration errors before suite setup. Repeated-filter semantics remain the same.

Fixes #1257.

Added CLI regressions (confirmed failing on the unchanged base) and configuration tests covering both flags, programmatic overrides, and OR composition. Focused tests, all 275 types specs with -race, and go vet ./... pass.

Local make ran 18 suites but remains red on five assertions: automatic process count, three bootstrap templates, and an Eventually report location. All five reproduce on base 510c8d5 with matched commands and environment (Go 1.27.1, GOMAXPROCS=4). An earlier race subprocess timeout did not recur in either comparison; its cause remains unconfirmed.

@Boulea7
Boulea7 marked this pull request as ready for review September 29, 2026 21:11
Copilot AI balanced review requested due to automatic review settings September 29, 2026 21:11
Copilot AI left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gingko panics if an incorrect regex is passed via focus/skip flags

2 participants

0