8000 Stop interrupt handler goroutines after suites finish by Boulea7 · Pull Request #1685 · onsi/ginkgo · GitHub
[go: up one dir, main page]
Skip to content

Stop interrupt handler goroutines after suites finish - #1685

Open
Boulea7 wants to merge 3 commits into
onsi:masterfrom
Boulea7:b29-ginkgo-1364
Open

Stop interrupt handler goroutines after suites finish#1685
Boulea7 wants to merge 3 commits into
onsi:masterfrom
Boulea7:b29-ginkgo-1364

Conversation

@Boulea7
@Boulea7 Boulea7 commented Sep 29, 2026
Copy link
Copy Markdown
Contributor

RunSpecs and PreviewSpecs leave interrupt handler goroutines running after returning, which makes process-wide leak checks fail. This stops each handler on return and covers normal, preview, repeated, and parallel suites. Fixes #1364.

Focused integration tests, go build ./..., and go vet ./... pass. Full make test still hits the same internal_integration Eventually timeout assertion failure reproduced on pristine master.

Copilot AI balanced review requested due to automatic review settings September 29, 2026 06:35
Copilot AI reviewed Sep 29, 2026
Copilot AI left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Boulea7
Boulea7 commented Sep 29, 2026
Copy link
Copy Markdown
Contributor Author

The Go stable job failed at integration/interrupt_test.go:75: the nested --timeout=5s run emitted only Test Suite Failed, without the fixture's Sleeping.... Ginkgo starts that timeout before compiling the fixture, so compile-budget expiry fits the output but is unconfirmed; the focused race/2-process test passes on this head and unchanged master. Could a maintainer rerun the failed job?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ginkgo v2 leaks goroutine

2 participants

@Boulea7
0