8000 Factor out version check code into a separate script. Call the script… by javajosh · Pull Request #199 · omacom/omakub · GitHub
[go: up one dir, main page]

Skip to content
This repository was archived by the owner on Aug 30, 2026. It is now read-only.

Factor out version check code into a separate script. Call the script… - #199

Merged
dhh merged 3 commits into
omacom:masterfrom
javajosh:check-version
Jul 13, 2024
Merged

dhh merged 3 commits into
omacom:masterfrom
javajosh:check-version

Conversation

@javajosh
@javajosh javajosh commented Jul 9, 2024
Copy link
Copy Markdown
Contributor

This is a redo of my previous PR. The git history is clean now, and the code is improved: distro name is properly checked, and the awk version comparison code is simplified.

The main purpose of this PR is to help others avoid the footgun of installing omakub over Ubuntu 22, which is the current LTS release.

… in install.sh after the omakub clone in boot.sh
Comment thread check-version.sh Outdated
}

if check_ubuntu_version; then
echo "Script is running on Ubuntu 24.04 or higher. Continuing execution..."
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just stay quiet if operating system is correct. That's the default assumption. So only output anything if we're failing.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Done.

Comment thread check-version.sh
Comment on lines +24 to 27
if ! check_ubuntu_version; then
echo "Script execution failed due to system requirements not being met." >&2
exit 1
fi
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remain silent on version check success.

@dhh
dhh merged commit be7635f into omacom:master Jul 13, 2024
burno-lima pushed a commit to burno-lima/omakdot that referenced this pull request May 15, 2026
Factor out version check code into a separate script. Call the script…
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0