Add Cupy space #1401
Add Cupy space #1401
Conversation
- expose trivial `none_context` - add `xfail_if` utility for conditional xfail - replace `almost_equal` by `pytest.approx` everywhere - extend more lp_discr tests to other impls - expose `array_module`, `array_cls` and `as_numpy` tools for handling arrays with different impls
- use native impl in diff_ops - remove CupyTensor.ufuncs, use base class method - add skip_if_no_cupy decorator
|
Checking new PR...
|
|
Is it mostly the tests or other stuff as well? |
|
Just a minor remark: We should require CuPy >= 4.0 since it's the only version available through conda (I heard they also work on Windows support for 5.0), and since it supports a lot of useful stuff that earlier versions don't, most of all FFTs. |
|
Basically someone (you and me) has done the same work exactly twice, one on master and one here. So there are merge conflicts everywhere. Join that with this branch actually containing some fundamental changes and you have a nightmare merge. I predict it will take at least a few days before it's all running smoothingly. W.r.t windows its already up, I'm using it atm. |
😬 😇
Cool, I guess through |
|
Question for @kohr-h. At what point (if at all) did |
|
This can only be the effect of |
|
Is there a list of the ufuncs that do this somewhere? |
>>> ufuncs = list(
... filter(
... lambda a: isinstance(getattr(np, a), np.ufunc),
... dir(np)
... )
... )
>>> c2r = list(
... filter(
... lambda f: any(t in getattr(np, f).types
... for t in('F->f', 'D->d', 'G->g')),
... ufuncs,
... )
... )
>>> c2r
['abs', 'absolute'] |
|
Thanks! |
This should replace #1231. I'm currently in the middle of a nightmarish merge of master changes and changes in this branch.
Edit: Overall my reaction to this PR atm is: Oh god please kill me. But I'll try to persevere.