8000 gl: replace a Stream buffer's storage on update instead of writing into it by indicozy · Pull Request #703 · not-fl3/miniquad · GitHub
[go: up one dir, main page]
Skip to content

gl: replace a Stream buffer's storage on update instead of writing into it #703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indicozy wants to merge 1 commit into from
Closed

gl: replace a Stream buffer's storage on update instead of writing into it #703

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/graphics/gl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ pub mod raw_gl {
struct Buffer {
gl_buf: GLuint,
buffer_type: BufferType,
usage: BufferUsage,
size: usize,
// Dimension of the indices for this buffer,
// used only as a type argument for glDrawElements and can be
Expand Down Expand Up @@ -1376,6 +1377,7 @@ impl RenderingBackend for GlContext {
let buffer = Buffer {
gl_buf,
buffer_type: type_,
usage,
size,
index_type,
};
Expand 7D46 Down Expand Up @@ -1404,7 +1406,16 @@ impl RenderingBackend for GlContext {
self.cache.store_buffer_binding(gl_target);
self.cache
.bind_buffer(gl_target, buffer.gl_buf, buffer.index_type);
unsafe { glBufferSubData(gl_target, 0, size as _, data.ptr as _) };
if buffer.usage == BufferUsage::Stream {
// The GPU may still be reading this buffer from an earlier draw. A
// glBufferSubData would then make mobile drivers (Adreno) copy the whole
// buffer before the write. glBufferData with the new data instead hands
// the driver fresh storage of just the bytes written: no copy, and no
// reallocation of the full capacity either.
unsafe { glBufferData(gl_target, size as _, data.ptr as _, gl_usage(&buffer.usage)) };
} else {
unsafe { glBufferSubData(gl_target, 0, size as _, data.ptr as _) };
}
self.cache.restore_buffer_binding(gl_target);
}

Expand Down
Loading
0