Repository navigation
Conversation
`NSLog` reads its first argument as a format string, and `log`, `load_file`'s "loading:" line and the panic hook all passed their message there. A message holding a format specifier made `NSLog` read arguments that were never passed: a `warn!` whose text included `%@` crashed the app with SIGSEGV, and any other `%` came out mangled. Each message now goes in as the argument to a fixed `%@` format, through `log`, so it prints as it is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
NSLogreads its first argument as a format string.native::ios::log, whichwarn!,error!and the otherlog-implmacros call on iOS, passed the message there, and so didload_file's "loading:" line and the panic hook. When a message holds a format specifier,NSLogreads arguments that were never passed. So an app that logs text it doesn't control, such as a parse error quoting a corrupt file, crashes insideNSLog:Change
logpasses the message as the argument to a fixed%@format, so it prints as it is.load_fileand the panic hook now log throughlog.Verification
music = %@ %s %ncrashed at launch when it logged the parse error withwarn!. With this change, the warning prints that line as written and the game carries on.cargo checkpasses foraarch64-apple-ios,aarch64-apple-tvosandaarch64-apple-darwin.🤖 Generated with Claude Code