Repository navigation
cfg-gate Android-only set_or_replace_display - #645
Merged
not-fl3 merged 1 commit intoJun 15, 2026
Merged
Conversation
The function is only called on Android (its own doc comment says so). Without the cfg gate, every other target (iOS, macOS, desktop, web) gets a `dead_code` warning on every build. Add `#[cfg(target_os = "android")]` so it's only compiled on the platform that actually uses it.
Owner
|
Done with the review! Really great job! Please ping me if I miss something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is only called on Android (its own doc comment says so). Without the cfg gate, every other target (iOS, macOS, desktop, web) gets a `dead_code` warning on every build. Adding `#[cfg(target_os = "android")]` so it's only compiled on the platform that actually uses it.