Repository navigation
Fix macOS cursor grab warp position - #629
Merged
Merged
Conversation
Owner
|
Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes incorrect cursor warp position on macOS when cursor grab is enabled.
Related Macroquad issue: not-fl3/macroquad#858
Problem
On macOS, enabling cursor grab can warp the cursor to an incorrect vertical position, often near the Dock/taskbar, instead of the center of the application content area.
The previous implementation computed the warp point from the outer
NSWindowframe and then passed that throughtransform_mouse_point(). This mixes AppKit window/frame coordinates with CoreGraphics cursor-warp coordinates and can produce an incorrect Y position, especially for non-square windows.Fix
Use the actual content view bounds, convert the view-center point through AppKit using
convertPoint:toView:andconvertRectToScreen:, then flip the Y coordinate for CoreGraphics before callingCGWarpMouseCursorPosition.This avoids manually combining outer window frame coordinates, titlebar/border offsets, scale factors, and screen-space conversion.
Tested
Tested locally on macOS Apple Silicon with a Macroquad-based app using
set_cursor_grab(true).Before this patch:
After this patch: