Repository navigation
Conversation
zig 0.17's build runner shows any test stderr under a `failed command:` line even when every test passes, and fy's tests printed ~800 lines: each case's input and result, fy's own output words, and the compile errors of tests that expect one. A clean run now prints nothing; a failing case still prints its input and what it got, and FY_TEST_VERBOSE=1 brings everything back. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Stall test stalls on purpose, and its warning was the only stderr left in a passing `zig build test`, which the build runner reports as a `failed command`. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…via log level Review fixes. errPrint is back as it was, so FY_DEBUG_ADAPTER and the dl-open message print under test again; only run's compile error is held (lastTestError) and a failing case prints it. The Stall test lowers std.testing.log_level itself instead of the watchdog checking is_test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With zig 0.17, the build runner prints a
failed command: …line above a test binary's stderr whenever there is any, even when every test passes. A cleanzig build testinfy/printed about 800 lines under that header:TestCase's input and resultdsp: k-e4: unsupported word…)At the root, Slab's suite printed the stall watchdog's warning from the test that stalls on purpose. Either way a passing run looked like a failure.
fy
outPrint(fy's output words) is silent unlessFY_TEST_VERBOSEis set.runno longer prints its compile error under test. It keeps it instead (lastTestError), and aTestCasethat errors prints its input, the error and that message.errPrintis unchanged, so opt-in traces such asFY_DEBUG_ADAPTERstill print.[tests]banner line is gone.Slab: the
Stalltest lowersstd.testing.log_levelwhile it stalls on purpose. The watchdog itself is unchanged.Tested with zig 0.17.0:
.zig-cache,fy/reports82/82 tests passedand the root reports585/586with 1 skipped. Neither prints anything else.FY_TEST_VERBOSE=1brings back all of fy's output.1 2 +expecting 4) prints the input along with the expected and actual valuesfy> 1 2 nosuchwordandUnknownWord: line 1: unknown word 'nosuchword'🤖 Generated with Claude Code