8000 corrected precedence error in Graph::removeNode by michaelficarra · Pull Request #33 · noflo/noflo · GitHub
[go: up one dir, main page]

Skip to content

corrected precedence error in Graph::removeNode - #33

Merged
bergie merged 1 commit into
noflo:masterfrom
michaelficarra:patch-1
Jul 13, 2012
Merged

bergie merged 1 commit into
noflo:masterfrom
michaelficarra:patch-1

Conversation

@michaelficarra
Copy link
Copy Markdown
Contributor

No description provided.

bergie added a commit that referenced this pull request Jul 13, 2012
corrected precedence error in Graph::removeNode
@bergie
bergie merged commit 0a56771 into noflo:master Jul 13, 2012
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
bergie added a commit that referenced this pull request Oct 12, 2026
…ibution, and the live DATA envelope

Work document #4 update #42, completing update #33's one-identifier-per-
graph-instance promise for subgraphs:

- Subgraph planes are registered at network build: the execution protocol
  walks the built network and registers every subgraph instance anchored
  to its node id (kind subgraph, parent chain, component name), with
  deterministic sg/<parent>/<node_id> ids reconciled per build. The sg/
  prefix is runtime-reserved — client-minted ephemeral ids using it are
  rejected with 0x17 on sync and ops. 0x16 now lists the full plane tree;
  dropping a subgraph plane is refused with 0x17, and dropping an
  ephemeral plane cascades to its subgraph descendants
- Telemetry attributes events to their effective plane: the engine's
  internal subgraph path resolves through the plane registry, so events
  sourced inside a nested subgraph are attributed to the subgraph's plane
  (the path never travels the wire). Per-plane flush grouping emits
  correctly attributed chunks
- Live 0x01 DATA telemetry carries the §7 envelope [src, tgt, value]
  built from the event's socket refs (dataEventEnvelope), with the value
  frugalized before enveloping so unserializable packets cannot take the
  refs down; group events keep their plain label payloads
- The tracefile projection follows the §7 payload rules exactly: the
  envelope is DATA-only — group events keep plain strings, connection
  events project to the flat four-string ref pair
- The bracket/stream event-type vocabulary renames to BEGIN_BRACKET/
  END_BRACKET (codes unchanged; the flowtrace-lineage begingroup/
  endgroup naming stays only in the recorder JSON input format),
  disambiguating from the graph-model group entity (INSERT_GROUP)

SPEC §5/§7 and the AsyncAPI channel descriptions follow; tests: subgraph
plane registration/reconciliation, reserved-prefix rejections, 0x15
refusal and cascade, effective-plane attribution, envelope assertions on
live and real-engine paths, and a full-stack subgraph e2e
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 14, 2026
The graph protocol handler is plane-aware: 0x10/0x11/0x12/0x14 carry the
plane_id (nil = the running main graph); a sync or op addressed to a
plane this runtime is not hosting is answered with 0x17 CMD_OP_REJECTED
— the explicit no, never silence — until the multi-plane registry lands
(the plane model is specified in work document noflo#4 updates noflo#28-noflo#33; the
registry is the staged next step of this wave).

RuntimeServer broadcasts runtime-initiated ops with the main plane id,
and the 0x02 auth response carries the runtime metadata and the
advertised capability ceiling alongside the granted mask, per the
external review's runtime:runtime and allCapabilities/capabilities
points.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0