8000 Do not spawn a compiler for every file. by rybesh · Pull Request #21 · noflo/noflo · GitHub
[go: up one dir, main page]

Skip to content

Do not spawn a compiler for every file. - #21

Merged
bergie merged 1 commit into
noflo:masterfrom
rybesh:compile-dir-at-once
May 23, 2012
Merged

bergie merged 1 commit into
noflo:masterfrom
rybesh:compile-dir-at-once

Conversation

@rybesh
@rybesh rybesh commented May 22, 2012
Copy link
Copy Markdown
Contributor

I was getting an EMFILE (too many open files) with the current approach of spawning a coffee process for every file (see below). This changes the Cakefile to compile each source directory all at once.

child_process.js:444
    throw errnoException(errno, 'spawn');
    ^
Error: spawn EMFILE
    at errnoException (child_process.js:481:11)
    at ChildProcess.spawn (child_process.js:444:11)
    at child_process.js:342:9
    at Object.execFile (child_process.js:252:15)
    at child_process.js:220:18
    at /Users/ryanshaw/Code/noflo/Cakefile:29:12
    at Object.oncomplete (/Users/ryanshaw/Code/noflo/Cakefile:45:20)

bergie added a commit that referenced this pull request May 23, 2012
Do not spawn a compiler for every file.
< B8F9 div class="d-flex">
@bergie
bergie merged commit 49a538d into noflo:master May 23, 2012
bergie added a commit that referenced this pull request May 23, 2012
bergie added a commit that referenced this pull request Oct 11, 2026
…matrix

The end-to-end multi-message and scope tests exposed the collector's
message-drop: the original assembly message was consumed on a waiting
activation, so later fields merged into nothing. CollectFields now
reads the message only on the complete path and caches the fields
control config across activations; single-value and bracketed-stream
inner outputs both map to their field (single packet unwraps, multi-
packet stream collects an array); Fork propagates the incoming IP's
scope to its clones. The ExtractField/ToField field config moves from
a one-shot control IIP to persistent node metadata.

Coverage matrix over the wrapped component: multiple sequential
messages stay paired with their own outputs, interleaved scopes stay
separated, bracketed inner streams collect as array fields, inner
errors accumulate into msg.errors while the message still relays.

Known issue (tests skipped with repro, work document #36): under
sequential multi-message load the collector's activation can read its
exported-inport message as undefined — a runtime buffer-lifecycle
finding for the Process API contract (work document #21), not a
wrapper bug.
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
More work on the commandline handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0