8000 FilterPropertyValue should not send objects not matching accept criteria by rybesh · Pull Request #20 · noflo/noflo · GitHub
[go: up one dir, main page]

Skip to content

FilterPropertyValue should not send objects not matching accept criteria - #20

Merged
bergie merged 2 commits into
noflo:masterfrom
rybesh:filterpvfix
Apr 3, 2012
Merged

bergie merged 2 commits into
noflo:masterfrom
rybesh:filterpvfix

Conversation

@rybesh
@rybesh rybesh commented Apr 2, 2012
Copy link
Copy Markdown
Contributor

I might be misunderstanding how FilterPropertyValue is intended to work, but the behavior implemented in this fix seems more correct (or at least intuitive) to me.

With this fix, there is only a "match" if the object has one of the the property-value pairs specified in the acceptance criteria. Also, when specifying p-v pairs using "p=v" strings, the value is evaluated, allowing matches against booleans and numbers.

bergie added a commit that referenced this pull request Apr 3, 2012
FilterPropertyValue should not send objects not matching accept criteria
@bergie
bergie merged commit fe4b2e7 into noflo:master Apr 3, 2012
bergie added a commit that referenced this pull request Oct 9, 2026
Phase 5 of work document #28: the 0x40 block server side, honest about
what the engine can do.

Implemented for real:
- START/STOP drive the network lifecycle through the host — the surface
  the wire was missing until work document #4 update #20; a rejected
  start surfaces as a 0x04 FAILED lifecycle event with the detail in an
  accompanying 0x04 ERROR event (update #1), finally exercised by a real
  command path
- HWM_SET records the network-global backpressure default on the host,
  applied when the network is next built; the engine resolves the
  high-water mark at edge construction, so a change while a network runs
  is deferred with an ERROR flowtrace event saying so

Honest about engine gaps (no faked semantics): pause/resume/step, data
breakpoints, and per-process disable have no engine primitive — stop()
tears down sockets and loses queued packets, violating pause semantics.
Those commands surface as unsupported events for the operator and as
ERROR flowtrace events for subscribed clients, never as silence or false
acknowledgments. Recording them as engine work items is the runtime's
verification job.

TelemetryProtocol.record is now public so sibling handlers can feed the
stream; NetworkHost carries pending high-water-mark configuration applied
at build time.
AsherBond pushed a commit to AsherBond/noflo that referenced this pull request Oct 12, 2026
A series of changes around commandline options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0