Repository navigation
FilterPropertyValue should not send objects not matching accept criteria - #20
Merged
Merged
Conversation
… values other than strings.
… values other than strings.
bergie
added a commit
that referenced
this pull request
Apr 3, 2012
FilterPropertyValue should not send objects not matching accept criteria
bergie
added a commit
that referenced
this pull request
Oct 9, 2026
Phase 5 of work document #28: the 0x40 block server side, honest about what the engine can do. Implemented for real: - START/STOP drive the network lifecycle through the host — the surface the wire was missing until work document #4 update #20; a rejected start surfaces as a 0x04 FAILED lifecycle event with the detail in an accompanying 0x04 ERROR event (update #1), finally exercised by a real command path - HWM_SET records the network-global backpressure default on the host, applied when the network is next built; the engine resolves the high-water mark at edge construction, so a change while a network runs is deferred with an ERROR flowtrace event saying so Honest about engine gaps (no faked semantics): pause/resume/step, data breakpoints, and per-process disable have no engine primitive — stop() tears down sockets and loses queued packets, violating pause semantics. Those commands surface as unsupported events for the operator and as ERROR flowtrace events for subscribed clients, never as silence or false acknowledgments. Recording them as engine work items is the runtime's verification job. TelemetryProtocol.record is now public so sibling handlers can feed the stream; NetworkHost carries pending high-water-mark configuration applied at build time.
AsherBond
pushed a commit
to AsherBond/noflo
that referenced
this pull request
Oct 12, 2026
A series of changes around commandline options
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I might be misunderstanding how
FilterPropertyValueis intended to work, but the behavior implemented in this fix seems more correct (or at least intuitive) to me.With this fix, there is only a "match" if the object has one of the the property-value pairs specified in the acceptance criteria. Also, when specifying p-v pairs using "p=v" strings, the value is evaluated, allowing matches against booleans and numbers.