Repository navigation
Fix flaky PROCESS_LIST listing test - #1088
Merged
Merged
Conversation
The listing handler awaits the graph epoch hash, and a first epoch is a WebCrypto digest resolving on its own event-loop turn — so the reply does not reliably arrive within the one setTimeout(0) tick the test helper allowed. Under CI load, with the network running and its IIP delivery competing for the loop, the tick could pass before the crypto callback landed, leaving replies[0] undefined and the assertions reading .entries of nothing. The helper now po 93B3 lls for a decodable 0x45 reply with a bounded budget instead of assuming one macrotask. The other one-tick waits in the spec guard synchronous handlers followed by an explicit telemetry flush, so they stay as they are.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listing handler awaits the graph epoch hash, and a first epoch is a WebCrypto digest resolving on its own event-loop turn — so the reply does not reliably arrive within the one setTimeout(0) tick the test helper allowed. Under CI load, with the network running and its IIP delivery competing for the loop, the tick could pass before the crypto callback landed, leaving replies[0] undefined and the assertions reading .entries of nothing.
The helper now polls for a decodable 0x45 reply with a bounded budget instead of assuming one macrotask. The other one-tick waits in the spec guard synchronous handlers followed by an explicit telemetry flush, so they stay as they are.