8000 i18n: internationalize remaining hardcoded display strings by nlminh · Pull Request #2 · nlminh/Toonflow-web · GitHub
[go: up one dir, main page]

Skip to content

i18n: internationalize remaining hardcoded display strings - #2

Open
nlminh wants to merge 1 commit into
masterfrom
feat/i18n-remaining-display-strings
Open

nlminh wants to merge 1 commit into
masterfrom
feat/i18n-remaining-display-strings

Conversation

@nlminh
@nlminh nlminh commented Jun 10, 2026
Copy link
Copy Markdown
Owner

Wraps the last hardcoded Chinese display strings in $t():

  • projectDialog visual/director manual tab labels (13) → new project.manual.* keys (en/zh-CN/zh-TW).
  • taskList state-filter options → existing workbench.task.stateRunning/stateCompleted keys.

Display-only — value/key/data unchanged. promptEditor TYPE_PREFIX.text deliberately left Chinese (it's a serialization token compared during parsing, not display). yarn build (vue-tsc + vite) passes.

Wrap project-dialog visual/director manual tab labels (13) in $t with
new project.manual.* keys (en/zh-CN/zh-TW); bind taskList state-filter
options to existing workbench.task.* keys. Display-only; value/key/data
unchanged. (promptEditor TYPE_PREFIX left Chinese — it's a serialization
token, not display.)
@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 05258db521

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

{ label: "分镜视频", value: "art_storyboard_video", data: "" },
{ label: "技法-导演规划", value: "director_planning_style", data: "" },
{ label: "技法-分镜表设计", value: "director_storyboard_table_style", data: "" },
{ label: $t("project.manual.prefix"), value: "prefix", data: "" },
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add manual tab translations for every supported locale

When the selected locale is th-TH, vi-VN, ja-JP, or ru-RU, these new project.manual.* lookups have no entries in the corresponding locale JSON files, even though those locales are registered in src/locales/index.ts. Vue-i18n will therefore fall back to English for the visual/director manual tabs while the rest of the UI is localized, so the internationalization change is incomplete for supported languages.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0