Repository navigation
add support for buildNpmPackage - #809
Conversation
|
@figsoda Could you please test this and give us a approval if you think it's good? Because it works on my end and I have a branch WIP that adds the other improvements. |
|
a quick skim looks good, i will do a more thorough review this weekend |
`npm_lacks_build_script` -> `npm_has_build_script` `serde_json::from_reader` -> `serde_json::from_str`: [1] [1]: https://docs.rs/serde_json/1.0.150/serde_json/fn.from_reader.html > Note that counter to intuition, this function is usually slower than > reading a file completely into memory and then applying `from_str` or > `from_slice` on it.
There was a problem hiding this comment.
thanks
side note: fetchNpmDeps support would be nice, but it would be quite a bit of duplicate code like CargoVendor with the current way things are laid out (1200 line function in main.rs), which I want to change in the future
|
@figsoda should the buildNpmPackage support not only just npm for the hash? Because I am sure there was cases where stuff like pnpm & yarn hashes are used. |
|
@eveeifyeve don't want to block this pr for this, but yes if you mean the pnpm and yarn hooks (usually with |
closes: #77