Repository navigation
Conversation
Member
|
@mergify queue |
☑️ The pull request will automatically be requeuedDetailsMerge queue reset: an external action moved the base branch head to e5a5418 |
3 of 14 tasks
This is the last commit before they bumped the MSRV to 1.84.
emilazy
force-pushed
the
push-upswkvnzppky
branch
from
January 23, 2025 21:42
2a02721 to
ed3299b
Compare
Member
|
Can this be rebased? |
Member
|
Bumping, would like to see this in! @emilazy |
Member
|
closed in favor of #655 (wasn't my original intention, but one change lead to another and I ended up updating a bunch of things) |
🟠 Waiting for conditions to matchDetails
|
Merge Queue Status🟠 Waiting for queue conditions Required conditions to enter a queue
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cargocrate dependency is perennially awkward. I think it would be better to shell out to Cargo commands and use thecargo_metadatacrate so we don’t have to keep doing this. Needs NixOS/nixpkgs#373096 to build (and was tested with--override-input nixpkgs github:NixOS/nixpkgs/pull/373096/head), but I’d like to get a release cut with this so that we don’t have to vendor a gigantic patch to theCargo.lockin Nixpkgs.