Repository navigation
kicbase: Prepare for updating go to 1.27.3 - #7
Merged
Merged
Conversation
We must merge this before we can update go to 1.27.3 (kubernetes#23938). The issue is that kicbase always use the source from main (security feature), so it uses GO_VERSION from this workflow (1.26.5) when building source from a forked PR with newer go version (e.g. 1.27.3) - which does not work. + env GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go build -o /home/runner/work/minikube/minikube/deploy/kicbase/auto-pause-amd64 ~/work/minikube/minikube/cmd/auto-pause ~/work/minikube/minikube go: ../../go.mod requires go >= 1.27.0 (running go 1.26.5; GOTOOLCHAIN=local)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We must merge this before we can update go to 1.27.3 (kubernetes#23938). The issue is that kicbase always use the source from main (security feature), so it uses GO_VERSION from this workflow (1.26.5) when building source from a forked PR with newer go version (e.g. 1.27.3) - which does not work.