-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Farsi/Persian Layout #206
Farsi/Persian Layout #206
Conversation
Interesting.. I guess that means we'll have to allow layouts to override the numeric layers, which isn't really something supported currently.
|
Have a look at 0ca7824, it should let you do the numbers by setting |
Is this still an issue on 0.1.6? It changed the RTL rendering to hopefully be slightly less wonky. |
It worked great, Thanks a lot. I updated main layouts accordingly. |
Generally, language-specific symbols (where they absolutely have to exist) are done by just adding them to the regular letters layout. |
it's not an issue with keyboard. brackets should be flipped to be displayed correctly in other devices, but Samsung devices flip them automatically regardless of keyboard so they shouldn't be flipped in order to be displayed correctly in Samsung devices. |
Any idea how they decide to do this? Based on the system language? |
Farsi and similar RTL languages like Arabic use RTL symbols for some characters(unlike Hebrew) like question mark( |
I added different layout for Samsung devices in thumb-key and same can be done here. I'm not familiar with android programming but is it possible to add some toggle switch in settings that overrides |
and it's not related to system language (using English myself), it behaves like this when it encounters RTL characters. other devices: most popular keyboards map brackets and similar characters to opposing direction characters in RTL layouts in order to display them correctly but since Samsung flip them again it would ruin this workaround. |
Hi I am new here , This is my first time . I want to make pull request , I don't know how , This site i svery complicated lol. I would like to share in creating Arabic lazout. What should I do ? I have zero experience in Programming. |
@AhmadMoradDoctor Let's make a separate issue for this, since it's a separate layout (as far as I'm aware). I've filed #210. But in short, the process is:
Optionally, if you have Android Studio (https://developer.android.com/studio) then it should show you live previews for your layout as you edit it. Otherwise any plain text editor (such as Notepad) should work. |
Okay, added a generic workaround for RTL bracketing in d4c357c. |
Are the paragraph symbols intentional? |
just tried it and its working great, thanks. |
yeah, I'm trying to display RLM character visually and I thought maybe |
I don't use RTL myself so I have no idea what's comfortable or expected for RTL users. |
Hm, might be.. :/ |
Not sure what you mean here :/ maybe we can open a separate issue for that? |
visualOverride = ActionVisual.Label("¶‹"), | ||
visualOverride = ActionVisual.Label( | ||
"¶‹", | ||
directionOverride = TextDirection.RightToLeft |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should be TextDirection.LeftToRight
to be displayed as ¶‹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The core issue seems to be that they get rendered outside of the |
I Added Farsi/Persian layout based on MessageEase and Thumb-Key(Far better layout for Farsi) layouts and made Farsi numeric and numeric mini layouts but I have no idea how to add them properly, I tried to add them to
NumericLayerOption
but since only 1 numeric keyboard can be used at a time, it can't be used beside English numeric layout and I'm not sure how to merge separate layouts with separate symbols layout.there can be some improvements:
I didn't change shifted symbols.
I commented
TextDirection
workaround for RTL languages because Samsung devices flip these characters automatically regardless of keyboard and ruin this workaround.I used
visualOverride
in order to display some characters better but I have no idea aboutforceRawKeyEvent
variable.