8000 Pipeline jinja by ewels · Pull Request #880 · nf-core/tools · GitHub
[go: up one dir, main page]

Skip to content

Pipeline jinja - #880

Merged
ewels merged 19 commits into
nf-core:devfrom
ewels:pipeline-jinja
Mar 16, 2021
Merged

ewels merged 19 commits into
nf-core:devfrom
ewels:pipeline-jinja

Conversation

@ewels
@ewels ewels commented Mar 15, 2021
Copy link
Copy Markdown
Member

Port the pipeline template to use Jinja2 directly instead of cookiecutter, following on from this process for the module template in #878

Makes for cleaner code, nicer file structures (no more file paths with annoying curly braces) and one fewer dependencies.

@codecov
codecov Bot commented Mar 16, 2021 •
Copy link
Copy Markdown

Codecov Report

Merging #880 (f6e0cf5) into dev (fa17a9e) will increase coverage by 0.12%.
The diff coverage is 92.30%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #880      +/-   ##
==========================================
+ Coverage   70.52%   70.65%   +0.12%     
==========================================
  Files          33       33              
  Lines        3651     3673      +22     
==========================================
+ Hits         2575     2595      +20     
- Misses       1076     1078       +2     
Impacted Files Coverage Δ
nf_core/sync.py 51.83% <ø> (ø)
nf_core/__main__.py 61.33% <66.66%> (ø)
nf_core/lint/template_strings.py 85.00% <75.00%> (ø)
nf_core/create.py 93.68% <94.23%> (-0.77%) ⬇️
nf_core/lint/__init__.py 79.72% <100.00%> (ø)
nf_core/modules/create.py 63.57% <100.00%> (ø)
nf_core/schema.py 86.51% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa17a9e...f6e0cf5. Read the comment docs.

@ewels ewels added ready-for-review template nf-core pipeline/component template labels Mar 16, 2021
@maxulysse
Copy link
Copy Markdown
Member

Love the idea

@KevinMenden
Copy link
Copy Markdown
Contributor

Okay everything worked fine for me. Run the same commands with this and the old cookiecutter tool.

  • All module files are identical
  • Did not catch any differences in pipelines created from the template
  • --force works for overwriting a module

Will look a bit deeper to be even more on the safe side but so far everything looks good! 👍

@ewels
ewels merged commit a44bf6c into nf-core:dev Mar 16, 2021
@ewels
ewels commented Mar 16, 2021
Copy link
Copy Markdown
Member Author

Approved on Slack ✅

@ewels
ewels deleted the pipeline-jinja branch March 16, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

template nf-core pipeline/component template

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0