8000 modules: Make conda-lock path always relative to repo root in `meta.yml` by JulianFlesch · Pull Request #4612 · nf-core/tools · GitHub
[go: up one dir, main page]

Skip to content

modules: Make conda-lock path always relative to repo root in meta.yml - #4612

Open
JulianFlesch wants to merge 8 commits into
nf-core:devfrom
JulianFlesch:fix-conda-lock-path
Open

JulianFlesch wants to merge 8 commits into
nf-core:devfrom
JulianFlesch:fix-conda-lock-path

Conversation

@JulianFlesch
Copy link
Copy Markdown
Contributor

Currently running from a directory that is not the project root (with -d) writes paths to meta.yml that are relative to the run directory, instead of the project root.

Example:

$ uv run nf-core m containers create fastqc -d copy_of_modules/

produces this containers section:

containers:
  ...
  conda:
    linux/amd64:
      lock_file: copy_of_modules/modules/nf-core/fastqc/.conda-lock/linux_amd64-bd-b342db7b694c9af4_1.txt
    linux/arm64:
      lock_file: copy_of_modules/modules/nf-core/fastqc/.conda-lock/linux_arm64-bd-7c8a53b986d9a000_1.txt

@JulianFlesch
JulianFlesch requested a review from mashehu November 13, 2026 08:00
@JulianFlesch
Copy link
Copy Markdown
Contributor Author

@nf-core-bot changelog

@codecov
codecov Bot commented Nov 13, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.88%. Comparing base (2265cec) to head (021887d).
⚠️ Report is 1 commits behind head on dev.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu mashehu changed the title Fix conda lock path modules: Make conda-lock path always relative to repo root in meta.yml Nov 13, 2026
@mashehu
mashehu commented Nov 13, 2026
Copy link
Copy Markdown
Member

@nf-core-bot changelog

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0