8000 fix(modules): support container builds for installed nf-core modules by Daesun-Ryu · Pull Request #4551 · nf-core/tools · GitHub
[go: up one dir, main page]

Skip to content

fix(modules): support container builds for installed nf-core modules - #4551

Open
Daesun-Ryu wants to merge 1 commit into
nf-core:devfrom
Daesun-Ryu:fix/4508-installed-module-containers
Open

Daesun-Ryu wants to merge 1 commit into
nf-core:devfrom
Daesun-Ryu:fix/4508-installed-module-containers

Conversation

@Daesun-Ryu
Copy link
Copy Markdown

Fixes #4508

Pipeline container builds currently discover only modules/local, so installed modules under modules/nf-core are unavailable for selection. Extend discovery to both locations and construct installed components using their repository and relative module paths.

Selection accepts exact module names, module families and explicit local/ or nf-core/ qualifiers. Exact matches take precedence over family matches; ambiguous unqualified names raise an actionable error. Local module names and existing local builds remain supported. Interactive selection uses qualified display names without changing component identities.

Validation:

  • RED: the installed-module discovery regression fails with the current dev constructor/discovery methods substituted in memory; it passes with this branch.
  • 20 focused installed-module and container-lint tests passed.
  • 54 container tests and 4 supplementary integration checks passed under WSL. These use mocks at external Git/network, Nextflow configuration, Prettier and Wave boundaries; discovery, selection and component construction execute locally. The focused tests overlap with this suite.
  • Ruff check/format, Python compilation and Git whitespace checks passed for the two changed files.
  • A Windows run of the broader fixture suite encountered an unchanged pipeline-template path separator error; the supported WSL run above passed.

Not run: a live Wave image build, full Nextflow/Prettier end-to-end execution, or the entire repository test suite. Hosted CI remains the next independent check.

This change and its tests were developed with AI assistance and reviewed against the current upstream code.

  • Describe the change and link the issue.
  • Add regression tests for the changed behavior.
  • Changelog entry (the repository's PR-title automation can supply it).
  • Documentation update (no new CLI option).

@mashehu
mashehu commented Oct 26, 2026
Copy link
Copy Markdown
Member

Please join the github org via the slack channel so the CI runs for you.

Copy link
Copy Markdown
Author

I've joined the nf-core Slack and submitted the GitHub organisation invitation request: https://nfcore.slack.com/archives/CEB982K2T/p1793301062585819.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0