Repository navigation
fix(modules): support container builds for installed nf-core modules - #4551
Open
Daesun-Ryu wants to merge 1 commit into
Open
Daesun-Ryu wants to merge 1 commit into
Daesun-Ryu wants to merge 1 commit into
Conversation
Member
|
Please join the github org via the slack channel so the CI runs for you. |
Author
|
I've joined the nf-core Slack and submitted the GitHub organisation invitation request: https://nfcore.slack.com/archives/CEB982K2T/p1793301062585819. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4508
Pipeline container builds currently discover only
modules/local, so installed modules undermodules/nf-coreare unavailable for selection. Extend discovery to both locations and construct installed components using their repository and relative module paths.Selection accepts exact module names, module families and explicit
local/ornf-core/qualifiers. Exact matches take precedence over family matches; ambiguous unqualified names raise an actionable error. Local module names and existing local builds remain supported. Interactive selection uses qualified display names without changing component identities.Validation:
devconstructor/discovery methods substituted in memory; it passes with this branch.Not run: a live Wave image build, full Nextflow/Prettier end-to-end execution, or the entire repository test suite. Hosted CI remains the next independent check.
This change and its tests were developed with AI assistance and reviewed against the current upstream code.