Repository navigation
Add -w/--fail-warned to nf-core pipelines schema lint - #4503
Open
qiaobochi040726-source wants to merge 1 commit into
Open
qiaobochi040726-source wants to merge 1 commit into
qiaobochi040726-source wants to merge 1 commit into
Conversation
Warnings during schema lint can now fail the command for use in CI.
Member
|
Please join the github org via the slack channel so the CI runs for you. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add
32BF
this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3123.
-w/--fail-warnednow makesnf-core pipelines schema lintexit 1 when it hits a warning, so it can gate CI. Without the flag nothing changes.Verified with the new test in tests/test_cli.py, plus running the function directly: no flag returns normally,
-wexits 1.