Repository navigation
Conversation
…heck The export_plots value check in the multiqc_config lint test didn't check ignore_configs before failing, unlike the report_comment check right above it in the same function. This meant listing export_plots under .nf-core.yml's lint.multiqc_config ignore list had no effect -- the presence check (does the key exist at all) respected it, but the value check (is it true) didn't, so pipelines that deliberately keep export_plots: false (e.g. to avoid large PDF/plot exports from a large pipeline) could never silence this specific failure the documented way. Added the same `if "export_plots" not in ignore_configs:` guard used by report_comment, and a regression test (test_multiqc_incorrect_export_plots_ignored) mirroring the existing ignore-list test patterns in this file. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
9 of 14 tasks
mashehu
approved these changes
Oct 2, 2026
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
@nf-core-bot changelog |
Member
|
@nf-core-bot fix linting |
Contributor
|
mashehu
reviewed
Oct 5, 2026
mashehu
approved these changes
Oct 5, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The export_plots value check in the multiqc_config lint test didn't check ignore_configs before failing, unlike the report_comment check right above it in the same function. This meant listing export_plots under .nf-core.yml's lint.multiqc_config ignore list had no effect -- the presence check (does the key exist at all) respected it, but the value check (is it true) didn't, so pipelines that deliberately keep export_plots: false (e.g. to avoid large PDF/plot exports from a large pipeline) could never silence this specific failure the documented way.
Added the same
if "export_plots" not in ignore_configs:guard used by report_comment, and a regression test(test_multiqc_incorrect_export_plots_ignored) mirroring the existing ignore-list test patterns in this file.
PR checklist
CHANGELOG.mdis updateddocsis updated