8000 fix(lint): respect ignore_configs for multiqc_config's export_plots check by jtremblay · Pull Request #4492 · nf-core/tools · GitHub
[go: up one dir, main page]

Skip to content

fix(lint): respect ignore_configs for multiqc_config's export_plots check< 8000 span class="sr-only"> - #4492

Open
jtremblay wants to merge 5 commits into
nf-core:devfrom
jtremblay:fix/multiqc-config-export-plots-ignore
Open

jtremblay wants to merge 5 commits into
nf-core:devfrom
jtremblay:fix/multiqc-config-export-plots-ignore

Conversation

@jtremblay
Copy link
Copy Markdown

The export_plots value check in the multiqc_config lint test didn't check ignore_configs before failing, unlike the report_comment check right above it in the same function. This meant listing export_plots under .nf-core.yml's lint.multiqc_config ignore list had no effect -- the presence check (does the key exist at all) respected it, but the value check (is it true) didn't, so pipelines that deliberately keep export_plots: false (e.g. to avoid large PDF/plot exports from a large pipeline) could never silence this specific failure the documented way.

Added the same if "export_plots" not in ignore_configs: guard used by report_comment, and a regression test
(test_multiqc_incorrect_export_plots_ignored) mirroring the existing ignore-list test patterns in this file.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

…heck

The export_plots value check in the multiqc_config lint test didn't
check ignore_configs before failing, unlike the report_comment check
right above it in the same function. This meant listing export_plots
under .nf-core.yml's lint.multiqc_config ignore list had no effect --
the presence check (does the key exist at all) respected it, but the
value check (is it true) didn't, so pipelines that deliberately keep
export_plots: false (e.g. to avoid large PDF/plot exports from a large
pipeline) could never silence this specific failure the documented way.

Added the same `if "export_plots" not in ignore_configs:` guard used by
report_comment, and a regression test
(test_multiqc_incorrect_export_plots_ignored) mirroring the existing
ignore-list test patterns in this file.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@codecov
codecov Bot commented Oct 2, 2026 •
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.21%. Comparing base (9848539) to head (f398a91).

❗ There is a different number of reports uploaded between BASE (9848539) and HEAD (f398a91). Click for more details.

HEAD has 132 uploads less than BASE
Flag BASE (9848539) HEAD (f398a91)
python-3.10 184 52

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu
mashehu commented Oct 2, 2026
Copy link
Copy Markdown
Member

@nf-core-bot changelog

@mashehu
mashehu commented Oct 5, 2026
Copy link
Copy Markdown
Member

@nf-core-bot fix linting

@github-actions
github-actions Bot commented Oct 5, 2026
Copy link
Copy Markdown
Contributor

⚠️ Cannot proceed with deployment

This Action has been explicity configured to prevent deployments from forks. You can change this via this Action's inputs if needed

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0