8000 Add a pre-commit hook that disallows the .view() operator by prototaxites · Pull Request #4496 · nf-core/tools · GitHub
[go: up one dir, main page]
Skip to content

Add a pre-commit hook that disallows the .view() operator - #4496

Open
prototaxites wants to merge 3 commits into
nf-core:devfrom
prototaxites:pre-commit-disallow-view
Open

Add a pre-commit hook that disallows the .view() operator#4496
prototaxites wants to merge 3 commits into
nf-core:devfrom
prototaxites:pre-commit-disallow-view

Conversation

@prototaxites
@prototaxites prototaxites commented Oct 5, 2026
Copy link
Copy Markdown
Contributor

Fallen afoul of this too many times...

Adds a pre-commit hook that blocks the .view() operator from being committed.

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
codecov Bot commented Oct 5, 2026 •
edited
Loading
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.40%. Comparing base (d1b168a) to head (adb5c4a).

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mashehu
mashehu requested changes Oct 5, 2026
View reviewed changes
@mashehu mashehu left a comment •
edited
Loading
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before we add this to the template can we test it in a few pipelines?

@prototaxites
prototaxites commented Oct 5, 2026
Copy link
Copy Markdown
Contributor Author

Good idea. I can nominate mag as a test case, anyone else want to volunteer?

@mashehu
mashehu commented Oct 5, 2026
Copy link
Copy Markdown
Member

maybe 8000 something to ask in the team-maintainers channel

@mashehu
mashehu commented Oct 6, 2026
Copy link
Copy Markdown
Member

could maybe be a option for nextflow lint? I know other linters check for left-over debugging statements.

@prototaxites prototaxites mentioned this pull request Oct 6, 2026
Open
@prototaxites
prototaxites commented Oct 6, 2026
Copy link
Copy Markdown
Contributor Author
8000

Also a good idea - I have proposed it here: nextflow-io/nextflow#7765

@prototaxites prototaxites mentioned this pull request Oct 7, 2026
Merged
11 tasks
@prototaxites
prototaxites commented Oct 7, 2026
Copy link
Copy Markdown
Contributor Author

PR to test in mag: nf-core/mag#1120

Ben didn't seem too keen on the idea of adding this to the linter!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mashehu mashehu mashehu requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@prototaxites @mashehu
0