8000 avoid prek input overload and forward `--verbose` to it by mashehu · Pull Request #4272 · nf-core/tools · GitHub
[go: up one dir, main page]

Skip to content

avoid prek input overload and forward --verbose to it - #4272

Open
mashehu wants to merge 3 commits into
nf-core:devfrom
mashehu:make-prek-more-verbose
Open

mashehu wants to merge 3 commits into
nf-core:devfrom
mashehu:make-prek-more-verbose

Conversation

@mashehu
@mashehu mashehu commented May 8, 2026
Copy link
Copy Markdown
Member

No description provided.

@codecov
codecov Bot commented May 8, 2026 •
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.30435% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.65%. Comparing base (df6d1da) to head (724e5c1).
⚠️ Report is 41 commits behind head on dev.

Files with missing lines Patch % Lines
nf_core/pipelines/lint_utils.py 77.77% 2 Missing ⚠️

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mashehu
mashehu force-pushed the make-prek-more-verbose branch from cea43bb to 356a640 Compare June 30, 2026 08:17
@mashehu
mashehu force-pushed the make-prek-more-verbose branch from 356a640 to 11d72fc Compare October 23, 2026 10:19
@mashehu mashehu added this to the 4.3.0 milestone Oct 23, 2026
@mashehu
mashehu force-pushed the make-prek-more-verbose branch from 11d72fc to c6d933e Compare October 28, 2026 13:38
@mashehu
mashehu requested a review from JulianFlesch October 28, 2026 13:38
@mashehu
mashehu force-pushed the make-prek-more-verbose branch from c6d933e to ecfcded Compare October 29, 2026 15:22
@mashehu
mashehu force-pushed the make-prek-more-verbose branch from ecfcded to 724e5c1 Compare October 30, 2026 09:40
import git
import git.config
import jinja2
import pathspec
@JulianFlesch JulianFlesch Oct 30, 2026 •
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this commen 8000 t

The reason will be displayed to describe this comment to others. Learn more.

Update pyproject.toml. This is not installed by default, only as dev dependency!


prettierignore = outdir / ".prettierignore"
if prettierignore.exists() and files:
spec = pathspec.PathSpec.from_lines("gitwildmatch", prettierignore.read_text().splitlines())
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also gitwildmatch seems to be deprecated?. https://python-path-specification.readthedocs.io/en/stable/upgrading.html

Suggested change
spec = pathspec.PathSpec.from_lines("gitwildmatch", prettierignore.read_text().splitlines())
spec = pathspec.PathSpec.from_lines("gitingore", prettierignore.read_text().splitlines())

or:

Suggested change
spec = pathspec.PathSpec.from_lines("gitwildmatch", prettierignore.read_text().splitlines())
spec = pathspec.GitIgnoreSpec.from_lines(prettierignore.read_text().splitlines())

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0