8000 Release 5.4.0 (Yellow Frog) by jfy133 · Pull Request #970 · nf-core/mag · GitHub
[go: up one dir, main page]

Skip to content

Release 5.4.0 (Yellow Frog) - #970

Merged
jfy133 merged 91 commits into
mainfrom
dev
Feb 2, 2026
Merged

jfy133 merged 91 commits into
mainfrom
dev

Conversation

@jfy133
@jfy133 jfy133 commented Jan 26, 2026
Copy link
Copy Markdown
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

PetcuBogdan and others added 30 commits October 23, 2025 10:13
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
Co-authored-by: Daniel Straub <42973691+d4straub@users.noreply.github.com>
@jfy133
jfy133 marked this pull request as ready for review January 26, 2026 13:20
@github-actions
github-actions Bot commented Jan 26, 2026 •
Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 223ef48

+| ✅ 382 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 5.4.0
  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in nextflow.config: Specify any additional parameters here

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md

✅ Tests passed:

Run details

  • nf-core/tools version 3.5.1
  • Run at 2026-02-02 11:16:59

@ggabernet ggabernet left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple of tests seem not to be passing with singularity

@charles-plessy charles-plessy left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me and @takiifujita-ui. We did not proofread the python code in details.

@nf-core-bot
Copy link
Copy Markdown
Member

Warning

Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: 3.5.1.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation.

@jfy133
jfy133 commented Feb 2, 2026
Copy link
Copy Markdown
Member Author

Final issue is due to

  [f8/066e9b] Submitted process > NFCORE_MAG:MAG:ASSEMBLY:POOL_SHORT_READS (group-0)
  [cd/35613a] Submitted process > NFCORE_MAG:MAG:ASSEMBLY:SHORTREAD_ASSEMBLY:MEGAHIT (group-0)
  ERROR ~ No such file or directory: https://zenodo.org/records/14897628/files/checkm2_database.tar.gz
  

Which I am replicating locally when running with conda and nf-test. This is is nothing we can do about currently as per https://blog.zenodo.org/2026/01/28/2026-01-28-improvements-and-support-expectations/

@jfy133
jfy133 merged commit b52fa53 into main Feb 2, 2026
150 of 157 checks passed
cavenel added a commit to nf-core/spatialvi that referenced this pull request Mar 20, 2026
See https://nfcore.slack.com/archives/C04QR0T3G3H/p1770036127541799:
We pushed a patch-release for nf-core tools (3.5.2) without any template changes. Unfortunately, this still results in the outdated comment being added to your PRs, e.g., nf-core/mag#970 (comment). Sorry, for that.
Either ignore them or just update the nf-core version in .nf-core.yml to 3.5.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

0