8000 v1.0.0 by HadrienG · Pull Request #17 · nf-core/mag · GitHub
[go: up one dir, main page]

Skip to content

v1.0.0 - #17

Merged
HadrienG merged 111 commits into
masterfrom
dev
Dec 21, 2019
Merged

HadrienG merged 111 commits into
masterfrom
dev

Conversation

@HadrienG
@HadrienG HadrienG commented Apr 18, 2019 •
Copy link
Copy Markdown
Member

ready for review

…, replace python2 checkM with BUSCO, loose python2 RefineM
Comment thread CHANGELOG.md Resolved
Comment thread CODE_OF_CONDUCT.md Resolved
@maxulysse
Copy link
Copy Markdown
Member

I noticed you have GCA_002596845.1_ASM259684v1_genomic.fna.gz and GCA_000840245.1_ViralProj14204_genomic.fna.gz in assets/data what are these files here for?

@apeltzer apeltzer left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things 👍

Comment thread .github/markdownlint.yml
@@ -0,0 +1,9 @@
# Markdownlint configuration file
default: true,
line-length: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not up2date anymore ;-)

# Markdownlint configuration file
default: true,
line-length: false
no-duplicate-header:
    siblings_only: true

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the file seems up to date with the template in nfcore/tools.

Comment thread CHANGELOG.md Resolved
Comment thread conf/awsbatch.config Resolved
Comment thread docs/configuration/local.md Resolved
Comment thread nextflow.config Resolved
Comment thread nextflow.config Resolved
@HadrienG
Copy link
Copy Markdown
Member Author

I noticed you have GCA_002596845.1_ASM259684v1_genomic.fna.gz and GCA_000840245.1_ViralProj14204_genomic.fna.gz in assets/data what are these files here for?

It's lambda and phix for the removal steps. Travis times out ~ 7 times of 10 if it has to download the files from the ncbi ☹️

@maxulysse maxulysse left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on finishing that release ;-)

@apeltzer
apeltzer self-requested a review December 21, 2019 10:16
@apeltzer
Copy link
Copy Markdown
Member

@HadrienG Go ahead :-)

@HadrienG
HadrienG merged commit 4c2f61c into master Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

0