8000 (mini.completion) Update `set_vim_settings`'s `shortmess` to hide completion messages by yamhab · Pull Request #554 · nvim-mini/mini.nvim · GitHub
[go: up one dir, main page]

Skip to content

(mini.completion) Update set_vim_settings's shortmess to hide completion messages - #554

Merged
echasnovski merged 1 commit into
nvim-mini:tmpfrom
yamhab:completion-shortmess
Nov 5, 2023
Merged

echasnovski merged 1 commit into
nvim-mini:tmpfrom
yamhab:completion-shortmess

Conversation

@yamhab
@yamhab yamhab commented Nov 4, 2023
Copy link
Copy Markdown
Contributor

Right now, mini.completion adds "c" to shortmess when set_vim_settings is enabled to reduce the amount of command line messages printed when completing. This PR also adds "C" to shortmess to further silence unnecessary messages. This has also already been referenced in #5 (comment) before. I've changed the code so that it detects to see if the user is using Neovim 0.9.0 or newer before adding the flag, and I also edited the appropriate tests.

@echasnovski
echasnovski changed the base branch from main to tmp November 5, 2023 15:37
@echasnovski
echasnovski merged commit be22248 into nvim-mini:tmp Nov 5, 2023
@echasnovski
echasnovski commented Nov 5, 2023 •
Copy link
Copy Markdown
Member

Thanks for the PR!

Yes, this makes sense. I've merged into a separate branch to polish a bit.

Edit: This now should be part of the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0