fix(nuxt): await page:finish hook on page enter with a hash link in scrollBehavior
#28997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielroe
reviewed
Sep 14, 2024
| @@ -28,26 +28,27 @@ export default <RouterConfig> { | |||
| } | |||
|
|
|||
| // Hash routes on the same page, no page hook is fired so resolve here | |||
| if (to.path === from.path) { | |||
| if (from.hash && !to.hash) { | |||
| if (to.path === from.path && !to.hash) { | |||
There was a problem hiding this comment.
should we check like this?
Suggested change
| if (to.path === from.path && !to.hash) { | |
| if (to.path === from.path && (!to.hash || (to.hash !== from.hash))) { |
There was a problem hiding this comment.
Wanted to list each case, which might help decide:
from.hash && !to.hash-->{ left: 0, top: 0 }!from.hash && to.hash-->{ el: to.hash, top: _getHashElementScrollMarginTop(to.hash), behavior }!from.hash && !to.hash-->false(no change)from.hash && to.hash-->false(no change)
Out of all 4, we don't want to satisfy the second bullet point; the inverse would be:
Suggested change
| if (to.path === from.path && !to.hash) { | |
| if (to.path === from.path && (!to.hash || from.hash)) { |
What do you think?
There was a problem hiding this comment.
Feels like we need a unit test covering the range of behaviours here.
It feels like the logic here isn't quite right, but I might be wrong
There was a problem hiding this comment.
Hello, don't want to rush you, but do we have any eta for this? I have used hash based navigation in a few places in my project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
resolves #28992
📚 Description
With
ssr:falseand page enter/refresh containing a hash link, we weren't awaiting thepage:finishhook. This caused_getHashElementScrollMarginTopto executeconst elem = document.querySelector(selector)too early and returnnull.