[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use '#teleports' target instead of 'body' #28490

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

test: use '#teleports' target instead of 'body' #28490

wants to merge 1 commit into from

Conversation

cernymatej
Copy link
Contributor

🔗 Linked issue

#28483

📚 Description

Since the recommended teleport target is now '#teleports', I figured it would be a good idea to update this test fixture as well. Not sure if it won't break something, though 🙈

@stackblitz StackBlitz
Copy link
stackblitz bot commented Aug 9, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@cernymatej cernymatej mentioned this pull request Aug 9, 2024
Closed
@huang-julien huang-julien changed the title test(teleports): use '#teleports' target instead of 'body' test: use '#teleports' target instead of 'body' Sep 1, 2024
@cernymatej cernymatej marked this pull request as draft September 18, 2024 15:50
@danielroe
Copy link
Member

We likely also need to update the test assertions.

@cernymatej
Copy link
Contributor Author

Yeah

I'm trying to figure out how to get rid of a playwright error to run the tests locally so that I can verify it after updating them.
image

@HigherOrderLogic
Copy link
Contributor
HigherOrderLogic commented Sep 19, 2024 •
edited
Loading

You need to run pnpm playwright-core install chromium.

@cernymatej
Copy link
Contributor Author

@danielroe
So, for the basic tests, the teleportId is set to 'nuxt-teleport':

nuxt/test/fixtures/basic/nuxt.config.ts

Line 19 in 52faf52

teleportId: 'nuxt-teleport',

There is already a test case for it:

nuxt/test/basic.test.ts

Line 2700 in 52faf52

it('should render teleports to app teleports element', async () => {

Is it worth keeping the <teleport to="body"> test, given that this is a use case that is not recommended?
Should the default case be tested as well? If so, should I test it under a separate Nuxt instance, since the one in the basic tests has a custom teleportId & teleportTag ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe Awaiting requested review from danielroe danielroe is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
3.x test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cernymatej @danielroe @HigherOrderLogic