[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump pnpm and adopt the "catalog" feature #28110

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexbit-codemod
Copy link
@alexbit-codemod alexbit-codemod commented Jul 11, 2024

🔗 Linked issue

Resolves #28109

📚 Description

Maintaining unique dependency versions in a workspace is easier with catalogs, preventing runtime conflicts, reducing bundle size, simplifying upgrades by editing a single catalog entry, and minimizing git merge conflicts.

Caveats
The pnpm update command does not yet support catalogs.
To update dependencies defined in pnpm-workspace.yaml, newer version ranges will need to be chosen manually until a future version of pnpm handles this.

  • Check that there isn't already a PR that solves the problem the same way. If you find a duplicate, please help us reviewing it.
  • Read the contribution docs at https://nuxt.com/docs/community/contribution
  • Ensure that PR title follows conventional commits (https://www.conventionalcommits.org)
  • Update the corresponding documentation if needed.
  • Include relevant tests that fail without this PR but pass with it.

Copy link
stackblitz bot commented Jul 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/h3-nightly@2.0.0-1718872656.6765a6e None 0 528 kB pi0

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Install scripts npm/esbuild@0.20.2
  • orphan: npm/esbuild@0.20.2
🚫
Install scripts npm/esbuild@0.21.5
  • orphan: npm/esbuild@0.21.5
🚫
Install scripts npm/esbuild@0.23.0
  • orphan: npm/esbuild@0.23.0
🚫

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/esbuild@0.20.2
  • @SocketSecurity ignore npm/esbuild@0.21.5
  • @SocketSecurity ignore npm/esbuild@0.23.0

@danielroe
Copy link
Member

This looks great to me - we just need the following two issues to be resolved:

@alexbit-codemod
Copy link
Author

sure. ill keep an eye on those, update this PR, and let you know when ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt pnpm's catalog feature, improving maintainability and conflict resolution
2 participants